fix(click-outside): correctly remove shadow DOM event listeners #20273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ClickOutside directive uses global
onmousedown
andclick
events in the parent shadowRoot of the element when the element is inside the Shadow DOM.When unmounted, the directive tries to remove those event handlers, but since the element is already unmounted, it can't find the parent shadowRoot, so the events are never removed.
This causes VOverlay content clicks to behave incorrectly, closing menus and submenus when they should stay open.
Using beforeUnmount instead of unmounted to remove event handlers in ClickOutside directive solves the issue.
fixes #19616
Markup: